https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336
Jonathan Druart <jonathan.dru...@bugs.koha-community.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #15 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
---
1/ I think merge_with is more appropriate than merge_to
2/ + unless (my $to_bookseller = Koha::Acquisition::Bookseller->fetch({id =>
$mergeto})) {
$to_bookseller is never used
3/ merge_to method should not return the error, an error should be raised and
caught by the caller
4/ t/Bookseller.t is DB dependent, it should be moved to the appropriate dir
(and perltidied)
Note that I have not tested the patch set yet.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
