https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #9 from Katrin Fischer <[email protected]> ---
Hi Genevieve, some things to look out for next time:

1) Please don't use tabs, but 4 spaces in your patches. The QA tools can help
you to find such problems, instructions on how to install them are on the wiki:

 FAIL   C4/Circulation.pm
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 2100)
                forbidden pattern: tab char (line 2092)
                forbidden pattern: tab char (line 2098)
                forbidden pattern: tab char (line 2097)
                forbidden pattern: tab char (line 2094)

2) Please add line breaks to your patch descriptions as that makes them easier
to read, see here: https://wiki.koha-community.org/wiki/Commit_messages

3) Please include the test plan in the commit message next time.

I will attach an amended patch in a moment :)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to