https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer <[email protected]> --- I think this could be useful to some libraries as it is, but I agree, there are some catches. Some future variation could be: Cancel the old hold, inform the library, but do not send the information to the next patron yet (this would allow the library to take care of the hold, slip, etc.) before the patron appears at the circulation desk. Some notes from the initial code review: 1) The new notice template includes +Copy: <<items.copynumber>> but doesn't include the callnumber. I think it should be amended - without the callnumber it's not possible to identify the item in question. Also there are some capitalization issues: Canceled Hold Available for Different Patron 2) From the system preferene it's not clear that this feature is tied to the automatic cancellation: ExpireReservesAutoFill yes: "Do" no: "Don't" automatically fill the next hold using the item. If enabled, an email notification will be sent to either the email address defined in 3) The tests for for ModReserveAffect have been adapted, but there are no new tests the change itself. There are also no changes to the tests for the changed: CancelExpiredReserves CancelReserve Failing for 3) - please take care of adding tests for this new functionality relfecting the changes in the routines. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
