https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |ommunity.org --- Comment #19 from Jonathan Druart <[email protected]> --- (In reply to Jesse Weaver from comment #12) > I strongly believe that for consistency with the rest of Koha (and due to > frustrations that changing the autogenerated schema files causes), that the > sub allows_add_by should be moved to a Koha:: module. The code has no tie to > the uploaded_files table anyway. > > Koha::UploadedFiles might be a good name, as that could later easily become > a Koha::Objects subclass, but that's just a suggestion. I agree with Jesse, you are adding a new way to do something where we already have one. For instance, on Koha::Virtualshelf, there are several can_* methods taking a borrowernumber in parameter. It seems that it's exactly what you are achieving here. It would be better to stick on the current form or to suggest and move everything to another one. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
