https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904
David Cook <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #56 from David Cook <[email protected]> --- (In reply to Jonathan Druart from comment #54) > I personally do not like the idea to move the strings to the pl scripts. > Moreover we have tried to use the KohaDates plugin as much as possible in > template files, which you are reverting with this patch. I'm also not a fan. One of the major reasons for having a template system is to use it to manage your presentation (ie your strings). The Perl should be responsible for the logic. Personally, if we were to move some strings out of the templates, I'd want to move them to a resources file like you have in a lot of Java projects. You reference the string in the template using an identifier, and it makes changes and translations way easier. Of course, that would probably have a negative performance impact with Perl unless you're using Plack or mod_perl. My other question is... why are we using CGI::Session, if we're trying to move to Plack? I haven't thoroughly investigated the code, but I don't see this bug offering a lot of benefit to Koha. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
