https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775
--- Comment #16 from Katrin Fischer <[email protected]> --- Comment on attachment 49516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49516 Bug 15775 - User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page Review of attachment 49516: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15775&attachment=49516) ----------------------------------------------------------------- I really like the use of the Price plugin for formatting - I'd love to see that used everywhere and improved to show the currency symbol in some cases. Found a small regression in testing (see code comments below): ::: opac/opac-user.pl @@ +126,5 @@ > +my $checkoutsblockedamount = C4::Context->preference( 'noissuescharge' ); > +$checkoutsblockedamount ||=0; > +if ( C4::Context->preference( 'noissuescharge' ) && > $borr->{amountoutstanding} > $checkoutsblockedamount ) { > + $borr->{'flagged'} = 1; > + $canrenew = 0; I think this change is not correct. noissuecharge should have no effect on renewals, as we have OPACFineNoRenewals to do that. With noissuecharge 5.00, OPACFineNoRenewals 100 and a fine of 5.01 on my account I can now no longer renew items I can renew without the patch. If I set noissuecharge to 5.02 I can renew with the patch applied. @@ +128,5 @@ > +if ( C4::Context->preference( 'noissuescharge' ) && > $borr->{amountoutstanding} > $checkoutsblockedamount ) { > + $borr->{'flagged'} = 1; > + $canrenew = 0; > + $template->param( > + checkouts_blocked_amount => sprintf ( '%.02f', > $checkoutsblockedamount ), Why not format the amount in the template like in the other cases? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
