https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400
--- Comment #8 from Jonathan Druart <[email protected]> --- (In reply to Owen Leonard from comment #5) > I'm having some problems with this patch: > > - It needs to be rebased (although I think I was able to correctly fix the > merge problems for testing). Done. > - In my tests the toolbar doesn't "stick' to the top of the viewport because > it has a margin on it. > - When it is floating, the toolbar isn't styled like it is on other pages > without this patch. There is a "floating" class which isn't getting added. Last patch reintroduces the floating class. > - It breaks other instances of the floating toolbar. I'm getting a JS error > on the cataloging page, for instance. Fixed, I have updated the second patch. > I'm not sure why, but having only "save" and "cancel" in the toolbar doesn't > feel right to me. But I agree that we need to be consistent, and I agree > that this page really needs some form of always-visible save button. As I said, the patches are here for discussion. I have understood from the discussion on bug 11088 that it's what you needed but you did not manage to implement it. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
