https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006
--- Comment #39 from Colin Campbell <[email protected]> --- (In reply to Marcel de Rooy from comment #22) > Created attachment 52480 [details] [review] > Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop > > Instead of adding yet another client timeout, I propose to use the > policy timeout that we also communicate in send_acs_status. > Although I agree that we perhaps better move it from institution to > account/login level, this c/should be done on another report. We > may have issues with existing configurations. > > In order to find a compromise between bug 13432 and the originally > proposed 15006 patch, this patch allows you to put a zero in the > policy timeout entry in the SIPconfig. > > The timeout logic is moved to a Sip.pm subroutine. Will add a test :) > > Test plan: > [1] Check timeout after login with policy/timeout > 0. > [2] Check timeout after login with policy/timeout = 0. (No timeout!) > [3] Check timeout after login with no policy timeout. Fallback to service. > [4] Check timeout after login with no policy and service timeout. > Should fallback to 30 seconds for both login process and after login. > > Signed-off-by: Marcel de Rooy <[email protected]> A problem is the timeout send back in acs_status is a transaction timeout. Strictly when that timeout elapses the client sould revert the current transaction but the connection should be maintained. There is of course already a timeout on the connection at tcp level if you are using keep alives -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
