https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906
--- Comment #58 from Jonathan Druart <[email protected]> --- (In reply to Alex Sassmannshausen from comment #57) > (In reply to Jonathan Druart from comment #52) > > (In reply to Alex Sassmannshausen from comment #49) > > > * t/db_dependent/Patron/CheckPrevCheckout.t: Renamed to... > > > * t/db_dependent/Patron/Borrower_PrevCheckout.t: ...this. > > > > Why? :) > > It struck me there was a pattern to the naming of the test files, I decided > to stick with that. Ha yes, got it! Actually the methods of Koha::Patron are tested in subtests of t/db_dependent/Koha/Patrons.t So it would make to move yours there. But it's 400 lines, so maybe not... Actually we have t/db_dependent/Patron.t t/db_dependent/Patrons.t t/db_dependent/Patron/*.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patron/*.t It's a bit... confusing, I agree :) So let's keep it as it, and I will try to clean that on another bug report. > > (In reply to Alex Sassmannshausen from comment #51) > > > - One patch now adds updated schema files for dbic. This will fix the > > > test > > > error (previously I assumed the tester would do this, but since the last > > > hackfest I no longer make that assumption). > > > > AFAIK that is still the case. > > Actually I personally submit a patch with a DONT_PUSH pattern in the commit > > message and let the RM generate the schema by himself. > > Interesting — I see the reason why you'd add DONT_PUSH — presumably to make > it clear to the RM that they should generate the schema files themselves… > > To clarify: do you literally just dump DONT_PUSH somewhere in the commit > message? > > Or is it part of the subject line or has a special location? Beginning of the commit message, something like: Bug 12345: [DO NOT PUSH] Schema files That could be a topic for the next meeting, in order to clarify things for everybody. Kyle, any thoughts? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
