https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686
--- Comment #20 from Jonathan Druart <[email protected]> --- (In reply to Kyle M Hall from comment #16) > (In reply to Jonathan Druart from comment #14) > > Kyle, could you have a look at this counter-patch? > > It seems easier to use the DBIC relationship than to create 3 new methods. > > While I agree, I think it adds confusion. The method name 'transfer' is a > verb, so it sounds like you would call $item->transfer() to initiate a > transfer. Can you change the method name to get_latest_transfer or something > like that? Indeed, good idea! I have chosen "get_transfer" which returns the current transfer, or undef if the item is not in transit. > I'm also a bit reticent about having a Koha Object return a DBIC object. > Would you create Koha::Item::Transfer(s) and return that? It would also > avoid a second db query just to get the branch name. Done, but I am not sure to understand how it will avoid the second query. I now use the Branches TT plugin to retrieve the branch name. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
