https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504
Tomás Cohen Arazi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |[email protected] --- Comment #43 from Tomás Cohen Arazi <[email protected]> --- I've tested this patches and found some issues: * Somehow, it is not deleting items: I ran this: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ misc/cronjobs/delete_items.pl --verbose --criteria 'holdingbranch="MPL"' --commit Where statement: where holdingbranch="MPL" Deleting '41' But the item is still there. I'm not sure why :-D MariaDB [koha_kohadev]> SELECT itemnumber,holdingbranch,homebranch FROM items WHERE itemnumber=41; +------------+---------------+------------+ | itemnumber | holdingbranch | homebranch | +------------+---------------+------------+ | 41 | MPL | CPL | +------------+---------------+------------+ 1 row in set (0.00 sec) * t/db_dependent/Items_DelItemCheck.t was missing the transaction, thus leaving cruft on the db (FIXED WITH A FOLLOWUP). This happened at some point when refactoring. * This is an opinionated item, and could be discussed, but I'd rather stick with --where instead of --criteria. I'd sign it if it was left as-is anyway. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
