https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311
--- Comment #11 from M. Tompsett <[email protected]> --- (In reply to Jonathan Druart from comment #10) > 1/ I am not sure that it is useful to display the warning when we arrive on > the page ("Information: Both row and column values must be selected."). It seemed to make sense to put a pre-emptive instruction, so the actual problem cases would be generally avoided. > 2/ How can be useful the changes done in the perl script? The value of $do_it is wrong without those changes, and causes nasty crashes. That is why I provided test coverage. > 3/ If you are submitting the form and one column is missing, the message is > displayed on the top of the page, which is not necessarily visible (on > relatively small screens). The whole screen looks bad on small screens. I just tried it on my phone. But the yellow at the top made me read it. > Why don't you just display a JS alert if at least one of the 2 infos is > missing? Because this is prettier? I'd prefer bootstrap in the staff client too, but that hasn't happened yet. Would this + alerts be okay? After all, it's really easy to click okay, and forget the message. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
