https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047
--- Comment #7 from alonso morgane <[email protected]> --- (In reply to Jonathan Druart from comment #3) > Quick code review: > > 1/ The default value for the new pref should be "off" > > 2/ Tabulation chars should be replaced with 4 tabs > > 3/ $tmp is rarely a correct variable name :) > > 4/ Additional fields are displayed (but not taken into account) on the mana > subscriptions search form > > 5/ The Koha::Branch[es] should not be added, use Koha::Librar[y|ies] instead > > 6/ Share> "Language of your sharing" is hidden on the right. > > 7/ "The export is done, thank you for your contribution." => It should not > be yellow (alert) but green (message) 1/ Paul says that it's better to have "on" in default value to promote the use of Mana (he'll discuss about it later) 2/3/7/ I'll clean my code 4/ the flied "deprecated" is not used yet because I didn't have the time to code the comment feature where librarians can say if a model is deprecated. I can remove the flied if you prefer. 5/ I'll do that 6/ Fixed Thanks for all your comments! I will do my best to apply them all. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
