https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch QA Contact|[email protected] |[email protected] |y.org | --- Comment #31 from Marcel de Rooy <[email protected]> --- QA Comment: Code looks good to me. eval { $avg = $sum / $total }; Not your code, but an eval around a non-zero division seems overkill. [% rating_avg_int = BLOCK %][% rating_avg | format("%.0f") %][% END %] This kind of construct does not look very pretty. Simplify? Passed QA -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
