https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Marcel de Rooy <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #16 from Marcel de Rooy <[email protected]> ---
my @valid_params = Koha::Patrons->_resultset->result_source->columns;

Normally, we should not touch the private underscored subs like _resultset
somewhere else?
We also have _columns in Koha/Object. Should that be made public?

In this specific case I even wonder if you should do this validation here in
REST or just pass the params to Objects (Patrons) and validate there if needed.
Would it be unexpected to return nothing if you search for an unexisting
column?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to