https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52832|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <[email protected]> --- Created attachment 54535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54535&action=edit Bug 16809: Silence authority warnings C4::Biblio::TransformHtmlToMarc Most of the floodiness is caused by accessing the cgi parameters in a context which is hard to determine. By purposefully saving the value to a scalar variable and using the variable, the issue disappears, and it will likely be a tiny tad faster as variable access is faster than multiple function calls. TEST PLAN --------- 1) Back up your intranet error log -- for example: cp ~/koha-dev/var/log/koha-error-log ~/koha-error-log.backup 2) Blank your intranet error log -- for example: echo > ~/koha-dev/var/log/koha-error-log 3) Log into your staff client 4) Click 'Authorities' 5) Click 'New from Z39.50' 5) Type 'Seuss' into 'Name (any):' and press enter 6) Click 'Import' beside the first link 7) Click 'Save' 8) Check your koha-error-log -- floody! 9) Apply patch 10) repeat steps 2-8 -- blank! 11) restore your intranet error log -- for example: mv ~/koha-error-log.backup ~/koha-dev/var/log/koha-error-log 12) run koha qa test tools Signed-off-by: Marcel de Rooy <[email protected]> Tested with addbiblio.pl. I would have preferred the scalar option in terms of simpler code, but this works too. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
