https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942
--- Comment #11 from Jonathan Druart <[email protected]> --- (In reply to Kyle M Hall from comment #10) > (In reply to Jonathan Druart from comment #8) > > (In reply to Jonathan Druart from comment #4) > > > Kyle, the following test should fail without this patch: > > > is( $prepared_letter->{content}, $hold->id(), 'Hold object used > > > correctly' > > > ); > > > > > > Could you please adapt it? > > > > The test still passes. > > They unit tests fail for me without the initial patch applied. % git fetch origin % git reset --hard origin/master % git clean -f -d % prove t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Letters/TemplateToolkit.t .. ok All tests successful. Files=1, Tests=13, 4 wallclock secs ( 0.06 usr 0.00 sys + 2.78 cusr 0.10 csys = 2.94 CPU) Result: PASS What I meant is that the test 'Hold object used correctly' successes when we are expecting it to fail. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
