https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390
--- Comment #55 from Jacek Ablewicz <a...@biblos.pk.edu.pl> --- (In reply to Marcel de Rooy from comment #54) > (In reply to Jacek Ablewicz from comment #53) > > (In reply to Marcel de Rooy from comment #49) > > > > > But take care with $type that you get from CalcFine. > > > It may not be what you expect it to be .. > > > > Looks like $type argument passed to UpdateFine() is always NULL / undef, > > setting it to the custom string is not possible in Administration -> > > Circulation and fines rules, or anywhere else in the system (not > > implemented?). But in case it's not NULL in the database, it affects just a > > fine description and the log entry. > > > > There doesn't seem to be anything wrong with it - ? > > Well anything? :) > These kind of things make maintaining code only harder. They implicitly > suggest something while it is not there. Couldn't agree more.. What I meant was: anything wrong with it in UpdateFine() in particular, which may make a proposed solutions insufficient or more problematic? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/