https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758
--- Comment #94 from Marcel de Rooy <[email protected]> --- Impressive work, Jonathan. Some findings so far for first two patches. Looks like I will not finish this one today. === Patch 1 C4/Labels/Label.pm L100 require Koha::Libraries; Remember you failed patches before for that? :) L101 # FIXME Is this used?? Not sure. But can you use those fields when you define a label in the editor or something? One of the templates contains the string in text and implicitly seems to suggest that. t/db_dependent/Reserves.t still fails (cause somewhere else) === Patch 2 Auth.pm: use for Branches removed; but still called. (Will be resolved, yes) TODO in C4/Search.pm L337 koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt: Exceptional [% l.branchname || 'UNKNOWN' %] Inconsistent? t/db_dependent/Holds/RevertWaitingStatus.t DBIx::Class::ResultSet::next(): [SQL::Abstract::__ANON__] Fatal: unexpected operator 'cancellationdate' with undef operand at /usr/share/koha/masterclone/Koha/Objects.pm line 168 Probably something similar as in Reserves.t -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
