https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #142 from Tomás Cohen Arazi <[email protected]> --- (In reply to M. Tompsett from comment #140) > Comment on attachment 55045 [details] [review] > Bug 11592: (QA followup) Simplify code > > Review of attachment 55045 [details] [review]: > ----------------------------------------------------------------- > > Just an eyeball. > > ::: catalogue/ISBDdetail.pl > @@ -33,5 @@ > > > > =cut > > > > -use strict; > > -#use warnings; FIXME - Bug 2505 > > I wouldn't change to Modern::Perl, unless all the Bug 2505 references are > fixed like this. I prefer to do it, and take responsability if it introduces a warning. Haven't seen one so far. > ::: opac/opac-showmarc.pl > @@ -58,4 @@ > > > > if ($view eq 'card' || $view eq 'html') { > > - # FIXME: GetXmlBiblio needs filtering later. > > - my $xml = $importid ? $record->as_xml(): GetXmlBiblio($biblionumber); > > GetXmlBiblio includes fields which aren't necessarily in GetMarcBiblio, if I > recall correctly. I'm not sure about this. The main difference is that GetMarcBiblio does some sanitization. I think it is safe. This is probably some reminder from the days when everything was done against biblioitems.marc instead of biblioitems.marcxml. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
