https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135
--- Comment #37 from Marcel de Rooy <[email protected]> --- Sorry, cannot finish this today. So some preliminary remarks here apart from the follow-ups: Tested regular overdue OK Tested changing a description OK Since my testing was not yet complete, I am not convinced yet :) Just thinking out loud: You select all accountlines with FU with an corresponding issue record, but what about hypothetical records FU that have an issue_id that does not have a record in issues anymore? Or does have issue_id NULL ? Should we do something about those two groups? What if the update reports 10/20 closed successfully? What should I do now as sysadmin with that result? General You use sub BorType in Overdues. It should actually not be there anymore (imho) with the new series of Koha Objects. Constructions with blocks and last statements are not really nice imo. If possible, prevent them? Remembers some goto's :) Adjusted one. Why do you use DateTime directly here: my $today = DateTime->now( time_zone => C4::Context->tz() ); accrune/ing should be accrue/accruing :) @Chris: Could you confirm that the script actually executed in your test? Did you check its results (xx records changed etc.) ? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
