http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6751

Paul Poulain <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P2
             Status|Signed Off                  |Failed QA

--- Comment #11 from Paul Poulain <[email protected]> 2012-02-15 
08:51:29 UTC ---
QA comment:
* the code itself is OK
* percritic still OK after patch applied
One thing that make me mark "failed QA" though:

1- the description is "Export checkin barcodes". I can't see anywhere that it's
related to "today" checked-in barcode. We will get new bug entries for this
"bug". Please rename to "Export today checkin barcodes" & add some information
to online help (koha-tmpl/intranet-tmpl/prog/en/help/members/readingrec.pl)

2- Last comment: the link is alone on readingrec.pl. I think it would be better
to add it as an option in the "More" toolbar.

Marking failed QA for #1, but as you'll submit a new patch, please also fix #2,
it will be more graphically consistent

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to