https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart <[email protected]> --- Hi Kyle, This patch does a bit more than advertise :) 1/ __MESSAGE_ID__ could be used everywhere, not only for phone notice. I think this should be covered by tests and documented somewhere (eventually added to the notice editor) 2/ + if ( $use_tt ) { + $letter->{content} =~ s/__MESSAGE_ID__/$message_id/g; + print $OUT $letter->{content}; + } Don't you think it would be better to retrieve the notice instead of duplicating the substitution? It would be less error prone. Btw, why does the script output something different if tt syntax is used? 3/ C4::Letters::_process_tt takes a new parameter, it should be covered by tests. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
