https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911
--- Comment #40 from Jonathan Druart <[email protected]> --- (In reply to Kyle M Hall from comment #39) > (In reply to Jonathan Druart from comment #38) > > (In reply to Kyle M Hall from comment #37) > > > Created attachment 55447 [details] [review] [review] [review] > > > Bug 16911 [QA Followup] - No need to 'use C4::Members' > > > > > > For some reason, this is causing t/db_dependent/Circulation.t to fail if > > > run independently. > > > > > > Signed-off-by: Kyle M Hall <[email protected]> > > > > I do not understand this patch, the subroutine AddEnrolmentFeeIfNeeded from > > C4::Members is called from Koha::Patron. It would make sense to use it. > > Do the unit tests fail for you without that patch? If not, maybe it's a > quirk of my environment. Because the call to AddEnrolmentFeeIfNeeded is > fully qualified, the 'use' is not needed, and would be unnecessary overhead > ( though incredibly minimal ). > > If the tests pass for you without that patch, I'd be happy to revert that > specific commit. No, the tests don't pass, but I don't understand why they do with this patch. I am suspecting there is bug hidden somewhere else :-/ -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
