Nick Clemens <> changed:

           What    |Removed                     |Added
                 CC|                            |
             Status|Signed Off                  |Failed QA

--- Comment #8 from Nick Clemens <> ---
I really like this feature and agree with Cait, the ability for users to save
their settings will make workflows easier for librarians

I agree with Jonathan too, this feature should be made usable for other pages
too, even if it is only introduced here first. 

1 - C4/Utils/DataTables/ - sub
This should be more generic, the work should be done in a function that can be
passed data from any page

2 - The script should be moved ot a javascript files for inclusion when
necessary, and can then be triggered by code on each page.

3 -The current code calls the service function each time the table is rendered,
so a sort will also make a call, this should only happen when column view

4 - Ideally when a user restores all columns we shouldn't need to save their
data, maybe we only store columns that are exceptions?

5 - This should use the REST api and not an svc script

6 -  $schema->resultset('UsersColumnsSetting')->update_or_create 
This should use Koha::Object

You are receiving this mail because:
You are watching all bug changes.
Koha-bugs mailing list
website :
git :
bugs :

Reply via email to