https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397

--- Comment #9 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> 
---
Comment on attachment 56503
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56503
Bug 17397: Show name of librarian who created circulation message

Review of attachment 56503:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17397&attachment=56503)
-----------------------------------------------------------------

::: Koha/Patron/Message.pm
@@ +49,5 @@
>                and $self->message_type
>                and $self->branchcode;
>  
> +    my $userenv = C4::Context->userenv;
> +    $self->manager_id($userenv ? $userenv->{number} : 0);

Please provide tests.

::: circ/circulation.pl
@@ +587,5 @@
> +    $this_item->{message}        = $content->message;
> +    $this_item->{manager_id}     = $content->manager_id;
> +    $this_item->{name}           = 
> $content->_result->get_column('manager_firstname') . ' ' . 
> $content->_result->get_column('manager_surname');
> +
> +    push @messages, $this_item;

You should not need this loop. You can access the message's methods from the
template.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to