https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896
--- Comment #23 from Jonathan Druart <[email protected]> --- (In reply to Kyle M Hall from comment #22) > (In reply to Jonathan Druart from comment #21) > > (In reply to Kyle M Hall from comment #20) > > > (In reply to Jonathan Druart from comment #19) > > > > Kyle, what are you testing on t/db_dependent/Koha/Account.t? > > > > it seems that it is already covered by the tests on > > > > t/db_dependent/Accounts.t > > > > > > I did not add that unit test file. I'll just deprecate it since it is not > > > necessary. > > > > Then now you need to provide tests for these changes :) > > Jonathan, I'm not understanding, the additional behaviors are already being > unit tested by the unit tests for makepayment. Yes but now it's not makepayment that makes the job, but Koha::Account->pay (which is starting to be too big btw). Moreover the makepayment subroutine is not enough covered by tests. Feel free to ask someone else opinion if you disagree. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
