https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17431
--- Comment #17 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- (In reply to Lari Taskula from comment #12) > I'm not completely sure why changing the order of "use" in the test fixes > some issues like being unable to call GetItem in C4::Reserves. That seemed > to be the issue for returning 500 in POST /api/v1/holds. I came across with > similar issue in Reserves.t. Does the fix make sense and can somebody > explain what's going on? I really would like to understand what's happening here, there is something hidden we need to catch. Just a thought: diff --git a/Koha/REST/V1/Hold.pm b/Koha/REST/V1/Hold.pm index 7f0b1ff..ae1cd4d 100644 --- a/Koha/REST/V1/Hold.pm +++ b/Koha/REST/V1/Hold.pm @@ -77,6 +77,7 @@ sub add { my $biblio = C4::Biblio::GetBiblio($biblionumber); + warn $can_reserve; my $can_reserve = $itemnumber ? CanItemBeReserved( $borrowernumber, $itemnumber ) Make the tests fail again. I also see the following warning (several): item-level_itypes set but no itemtype set for item (1064) at /home/vagrant/kohaclone/Koha/Schema/Result/Item.pm line 698. when the tests pass, but not when they fail. Could someone else have a look and try to understand what's happened here? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/