http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7520
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] --- Comment #11 from Paul Poulain <[email protected]> 2012-02-21 13:52:33 UTC --- QA comment * the code itself is OK, use JSON, that is already a Koha dependancy * perlcritic compliant 2 things that make me mark this patch "failed QA" though: * a unit test for this script is needed (and should be easy to write) * an example of how/where to use this would be cool. A question: this script can be considered as a webservice right ? why not putting it into a specific directory where we could put this kind of script ? I don't request it, just suggesting. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
