https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246
Josef Moravec <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55166|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <[email protected]> --- Created attachment 58091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58091&action=edit [SIGNED-OFF] Bug 17246: Do no support arrayref to define multiple FK Currently you can call GetPreparedLetter like: $prepared_letter = GetPreparedLetter( ( module => 'test', letter_code => 'TEST_HOLD', tables => { reserves => [ $fk1, $fk2 ], }, ) ); It assumes that $fk1 is a borrowernumber and $fk2 a biblionumber. It seems hazardous to do this guess. I suggest to remove this feature and only allow hashref indeed. Test plan: Use different way to generate letters and make sure you do not reach the croak Signed-off-by: Josef Moravec <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
