http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7408
--- Comment #16 from Ian Walls <[email protected]> 2012-02-24 14:03:08 UTC --- I can agree that having a unified, integrated and systemic way of keeping track of when holds expire is a good one. This should be part of the Holds Rewrite project, as we'll be rethinking a great many aspects of the way we do Holds in Koha. I can also agree that it's better to allow a more granular approach to hold-not-picked-up fines than just the blanket charge. This part of the feature was added for one particular ByWater customer, who had a very simple use case. The idea was that if people were to start using the feature and demand more flexibility to it, it could later be expanded, but for just one library system, it wasn't worth developing more than necessary. The cronjob solved both the specific need of that library system, and the larger issue of holds expiry, without having to muck around with the already-bloated Circ Matrix. As for your (current) patch, there is a typo in the subroutine name (_GetExpireResevesSQL is missing an 'r'). The subroutine is an interesting approach to the problem; it's not done like that elsewhere in Koha, so I'm not sure how to feel about it. The patch also locks in the expiry date when the hold is marked as ready. If the Max Pickup Delay were to change while a hold is waiting, then the new expiry date would not be calculated, leading to incorrect cancellation and possibly incorrect fees. My cronjob-based patch uses the ReservesMaxPickupDelay that is current to when the expiry and possible fees are applied. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
