https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897
Owen Leonard <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Owen Leonard <[email protected]> --- I've done a quick run-through of this and nothing looks broken. The tests all pass. I think the biggest gap is documentation. There should be a help file for the whole process, especially the things which aren't self-explanatory. For instance: - What does the 'cyclical' setting do? - What is the purpose of the "Start" item in the stages and duration column of the manage items table? - What does the "In demand" setting do? I take it the process is: Create rota -> Add items -> Wait for cron job to put items in transit? I'm curious whether available items should be put in transit automatically after putting them on a rota. Minor problems: - Our capitalization rules say the heading should say "Stock rotation" instead of "Stock Rotation" https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_lower_cases_in_strings - I don't the the alert-style div is correct for showing a confirmation of items added. I would put the confirmation message in a <div class="dialog message"></div> and show a table of results below that. - In the manage items table, there is no <tr> wrapping <th>. - The page title and breadcrumbs should be made more specific for each page. For instance, when on the manage items page the breadcrumbs should be: Home › Tools › Stock rotation > Manage items This provides an easily accessible link back to the main stock rotation page. Suggestions: - Add a toolbar to the manage items page with a 'New rota' and 'Edit rota' buttons. - Move the add items forms to the top of the - In the manage items table, I think title and barcode should link to the bibliographic record and items page, respectively. - Make the manage items table a DataTable with sorting and searching. Unless you think the items table will typically hold so much data this would become cumbersome? - Should item status information be displayed in the manage items table? Is it relevant to the process to know whether something is checked out, lost, etc? - Since the drag-to-sort interaction is new to Koha it probably needs a hint at the top to suggest it. (Looks good and work well, though). I'm marking this as failed for now for the minor fixes and to get more information. Thanks. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
