https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239
--- Comment #87 from Josef Moravec <[email protected]> --- Thanks for testing and feedback Jonathan! (In reply to Jonathan Druart from comment #85) > Some quick remarks and questions: > - Is it expected to have these "big" buttons everywhere? Why do we want to > have bigger buttons? The buttons in bootstrap 3 are a bit bigger than in version 2 by default. So button "levels" in Koha remains the same, but the absolute size of button is different. We can shift it down in Koha if we really wan't, but I don't think it is neccesary - from my point of view it more comfortable to use bigger buttons, but it's just my opinion, I don't have any data about that for now... > Note that some buttons have not been converted. Many buttons weren't transformed to bootstrap ever yet, I plan to make followup (omnibus) bug for using bootstrap everywhere where it makes sense. Mayby some buttons which are new due to continuing the work on Koha master, I updated this patchset about a month ago - I can make a followup, or we can decide to make it on another bug, what do you think? > - Some JS code have been commented in cateditor-ui.inc. I did not get why it > is for. We should either add a comment to explain why it is commented, > remove the code or let it as before. > Yep, we should remove this code, it was for styling of modals, which is now made differently. I'll add the followup patch > Otherwise everything looks fine, great job! Thanks! ;) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
