https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063
--- Comment #24 from Alex Arnaud <[email protected]> --- (In reply to Marcel de Rooy from comment #23) > (In reply to Alex Arnaud from comment #22) > > For me there is two case: > > > > 1) The expiration date set by the patron is higher than the calculated > > expiration date (that take into account pickup delay and holiday). In this > > case, i think it is quite fair to overwrite the patron expiration date since > > he is not supposed to keep the item waiting beyond the library delay. This > > is what this patch does. > > > > 2) The patron expiration date is before the calculated expiration date. As > > the patron don't need the item after its own date, we could overwrite > > expirationdate with the one calculated. We need a adjustment to have this > > behavior. > > As indicated before, I would not overwrite the expiration date. > What about comment19 ? Not sure to understand. (In reply to Marcel de Rooy from comment #19) > (In reply to Andreas Hedström Mace from comment #18) > > Without having actually tested this bug, only reading the discussion, I > > would say that I have to agree with Sonia. > > > > As this new date is set after the material is checked in, it doesn't appear > > (at least to me) that the expire date set by the patron would be valuable > > anymore. And the added value of excluding dates that the library is closed > > from the number of day in ReservesMaxPickUpDelay, seem greater than any > > negative impact. > > Hi Andreas, > Thx for your feedback. > I read it again too now. This patch tries to achieve its goal by modifying > the expirationdate, while it actually should change this select in > CancelExpiredReserves? > > my $query = "SELECT * FROM reserves WHERE TO_DAYS( NOW() ) - TO_DAYS( > waitingdate ) > ? AND found = 'W' AND priority = 0"; > > If the holiday stuff is taken into account here, I am having the impression > that we achieve the same. Mabye Sonia or Alex can respond to that? The code here is just simplified since the expirationdate (with max pickup delay + holiday) has already been set at the check in time. So we just need to fetch reserves whose expirationdate is over. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
