https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Owen Leonard <oleon...@myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Owen Leonard <oleon...@myacpl.org> ---
I think this looks good, but there are some issues that need to be looked at:

I think that if there is no email address for the logged-in user's library the
page should not offer to email the librarian. In my test if I submit a report
to the librarian and there is no email address for my home library, the entry
saved in message_queue has an empty 'to_address' field.

There are HTML validation errors triggered by duplicate id attributes on form
fields. The form fields on the two different tabs should not have the same ids
(note that input name and id attributes do not have to match);

Also, in the OPAC (and soon to be the case in the staff client), page-specific
JavaScript goes into a special BLOCK which is processed in the footer include.
So instead of this, at the end of opac-reportaproblem.tt:

[% BLOCK jsinclude %][% END %]

<script type="text/javascript">
    $(document).ready(function(){
        $("#reportproblem").tabs();
    });
</script>

It should be:

[% BLOCK jsinclude %]
    <script type="text/javascript">
        $(document).ready(function(){
            $("#reportproblem").tabs();
        });
    </script>
[% END %]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to