https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196
--- Comment #130 from David Cook <[email protected]> --- Comment on attachment 58927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58927 Bug 17196: DB Changes Review of attachment 58927: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17196&attachment=58927) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +3926,5 @@ > + > +CREATE TABLE biblio_metadata ( > + `id` INT(11) NOT NULL AUTO_INCREMENT, > + `biblionumber` INT(11) NOT NULL, > + `format` VARCHAR(16) NOT NULL, I know this has already been pushed, but maybe the RM could add some comments to this SQL? In the comments, I think format was "USMARC, MARCXML, MiJ"? I'd maybe add a comment saying something like "ISO2709, XML, JSON", although maybe I'm misunderstanding how the field will actually be used... @@ +3927,5 @@ > +CREATE TABLE biblio_metadata ( > + `id` INT(11) NOT NULL AUTO_INCREMENT, > + `biblionumber` INT(11) NOT NULL, > + `format` VARCHAR(16) NOT NULL, > + `marcflavour` VARCHAR(16) NOT NULL, It seems unfortunate that we're using marcflavour here after divorcing this table from MARC in every other way. Although I don't know how else we'd do this. Both UNIMARC and USMARC share the same MARCXML schema, and if we can have non-XML data, we couldn't use "schema" instad of "marcflavour". Although if it were Dublin Core, you'd want to be able to specify that schema I reckon. Maybe a person could cheat and use a format of XML and a schema of UNIMARC or USMARC, and you'd use the actual MARCXML schema for both but you'd know you're dealing with one standard or the other. I don't know. I'm guessing all the work's actually be done on this one anyway, so I'm probably too late with these comments. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
