https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
Josef Moravec <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Needs Signoff |Failed QA --- Comment #13 from Josef Moravec <[email protected]> --- I am always for making Koha faster ;) I just did first round of testing: scripts generate_discrete_calendar.pl and add_days_discrete_calendar.pl needs to have set execution permission in filesystem the need to run generate_discrete_calendar.pl should be somehow documented in UI, adding holidays does not work without it and the can't know why qa tools complain: FAIL C4/Circulation.pm FAIL forbidden patterns forbidden pattern: tab char (line 3418) forbidden pattern: tab char (line 394) forbidden pattern: tab char (line 676) forbidden pattern: tab char (line 3575) forbidden pattern: tab char (line 3553) FAIL Koha/DiscreteCalendar.pm FAIL critic Variable declared in conditional statement at line 862, column 5. Declare variables outside of the condition. Variable declared in conditional statement at line 861, column 5. Declare variables outside of the condition. FAIL forbidden patterns forbidden pattern: tab char (line 413) forbidden pattern: tab char (line 412) forbidden pattern: tab char (line 411) FAIL pod Spurious text after =cut Spurious =cut command *** ERROR: in file Koha/DiscreteCalendar.pm FAIL spelling differnt ==> different FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/discrete_calendar.tt FAIL forbidden patterns forbidden pattern: tab char (line 440) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 7) forbidden pattern: tab char (line 439) forbidden pattern: tab char (line 441) FAIL misc/cronjobs/staticfines.pl FAIL valid Can't locate C4/DiscreteCalendar.pm in @INC (you may need to install the C4::DiscreteCalendar module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) Ad point 3 in your test plan: It would be better not to rely on existing branchcodes, but use TestBuilder to make one you need -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
