https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917
--- Comment #21 from M. Tompsett <[email protected]> --- (In reply to Jonathan Druart from comment #19) > Why do you want to replace AddMember calls with TestBuilder? 1) Because it fixes the failed tests. 2) Because none of the tests actually are testing whether a member was added correctly or not. (i.e. not t/db_dependent/Members.t) 3) Because putting in the userenv logic method seemed like the wrong fix compared to switching to TestBuilder. 4) Because TestBuilder generates a nicer patron record than the userenv logic that would have been added. 5) even with your change from bug 6782, there are still failures. TEST PLAN --------- vagrant up jessie cd kohaclone git checkout -b bug_17917 origin/master git bz apply 17917 y git checkout master sudo koha-shell -c "prove t/db_dependent" kohadev # This has faillures git checkout bug_17917 sudo koha-shell -c "prove t/db_dependent" kohadev # This drastically reduces the problems. Still kind of bummed about check_sysprefs failing when t/db_dependent, but not when individually. And, Reserves.t needs a patch from 13113 applied, because it got missed. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
