https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501
Jonathan Druart <jonathan.dru...@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58619|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- Created attachment 59348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59348&action=edit Bug 17501: Move getCategories and httpheaders from Upload.pm Class method getCategories has no strict binding to Upload.pm. While Upload.pm is now restricted to the actual uploading process with CGI hook, this routine fits better in the UploadedFile package. Class method httpheaders can be moved as well for the same reason. Note that it actually is an instance method. The parameter $name is dropped. Test plan: [1] Run t/db_dependent/Upload.t. [2] Check the categories in the combo box of tools/upload. [3] Check a download via tools/upload and opac-retrieve-file. Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io> Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/