https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #8 from Marcel de Rooy <[email protected]> --- (In reply to Jonathan Druart from comment #7) > I am stuck, I tried to provide tests to highlight the problem, but I do not > manage to make them fail. > There is something wrong in the code: > It seems that the same code is duplicated: > if ( $params{module} ) { > do something; > } else { > do almost the same thing; > } > > Except that in the first block, $_ is used, but is always undefined (not in > a loop). > This code sounds ugly and buggy, it may be good to fix it. Yeah. I saw the code; it is horrible. But this seems to fix at least one issue. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
