https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #133 from Jonathan Druart <[email protected]> --- Alex, Few more remarks: 1/ There is something wrong with the sql sample files for translated languages. The mandatory and optional files for the other languages have to be moved to the default directory as well. We will have to be meticulous to avoid regressions. 2/ You should also adapt xt/sample_notices.t, tests are failing after your patches 3/ Could you double check the module you use in installer/onboarding.pl, some are uselessly used. 4/ Double check the copyright lines you have added (+# Copyright (C) YEAR YOURNAME-OR-YOUREMPLOYER) 5/ You copied some existing javascript functions to onboardingstep2.tt. Do not duplicate existing code. You should also have a look at this template, the indentation in the javascript portion is weird. 6/ Same as 5 for onboardingstep3.tt 7/ summary.tt - you should not use <br/> tag, our translation tool does not handle sentences when they are split by html tag. That make the job really hard (and sometimes impossible) for translators. 8/ Copyright of summary.pl sounds totally wrong. 9/ Is this Summary info really useful? To me it looks like it should be moved to the help part. I am not sure it worth a new entry in the "More" menu. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
