https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
--- Comment #53 from Aleisha Amohia <[email protected]> --- (In reply to Jonathan Druart from comment #50) > (In reply to Jonathan Druart from comment #41) > > Aleisha, it seems that your last patch kept the 2 subroutines in C4::Items. > > Since you are not using them, you can remove them. > > Note that this is still valid, C4::Circulation::GetItemIssues is readded by > your patch whereas it has been removed by bug 17679. Fixed in the latest patch. (In reply to Katrin Fischer from comment #51) > (In reply to Jonathan Druart from comment #50) > > I'd like to get feedbacks about these few questions: > > 1. Maybe the pref AllowIssueNotes should be renamed AllowCheckoutNotes? > > I think the initial devs might not have been aware of our terminology: > https://wiki.koha-community.org/wiki/Terminology > Could we fix this later on in a separate patch later on? This has been > taking a long time already. I agree with Katrin - any other additional comments about language etc. can be fixed once this has passed, but would really like to get this through. Reattached patch removes the GetItemIssues from the patch. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
