https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
--- Comment #143 from Alex Buckley <[email protected]> --- In the commit I have just finished (soon to be attached to bug 17855) the following points have been addressed: 1/ I have made a new bug 18039 (assigned to myself but if someone else wants to take it on they are more than welcome to). This bug requires the movement of the mandatory and optional files of other languages into default directories. Because this is a complex job it is going to take significant testing and so I have placed the work for this in a new bug report to keep bug 17855 moving forwards. 2/ M.Tompsetts patch has addressed this issue as the xt test now returns a successful result of: xt/sample_notices.t ......... ok xt/single_quotes.t .......... ok xt/tt_valid.t ............... ok xt/verify-debian-docbook.t .. ok xt/yaml_valid.t ............. ok All tests successful. Files=5, Tests=90, 5 wallclock secs ( 0.05 usr 0.00 sys + 4.19 cusr 0.06 csys = 4.30 CPU) Result: PASS 3/ I assume you mean the use pragmas at the top of the onboarding tool. If this is the case in my most recent commit I have removed 7 more unused use pragmas. 4. I've fixed the copyright notice 5. I now include the js from categories.js, removing the duplicate js code in onboardingstep2.tt except for the assignment of the message variables and the enrollment_period function which is different for the onboarding tool to that in the categories.js 6. I've fixed the indentation of js in onboardingstep3.tt. Due to my password_match js function being slightly different to the one in members.js I have left that in onboardingstep3.tt additionally I have left the form validation js code in onboardingstep3.tt as there are different fields to validate than the memberentrygen.tt. Making the js form validation in members.js work for both the onboardingstep3.tt and memberentrygen.tt can be done in a later bug as a lot of testing would be required. 7. I have now removed summary.tt which can be added in a later bug 8. Removed summary.pl same reason as above 9. Removed summary info same reason as above -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
