https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691
--- Comment #4 from Aleisha Amohia <[email protected]> --- (In reply to M. Tompsett from comment #2) > Then the weird: > display_patron_image -- something isn't quite right. > It is only set if there is an image to display, whereas the preference > change makes no such distinction. cardnumber is currently only set if there > is an image, you could expand the condition. Strangely, cardnumber isn't > even used in the template currently. The image logic is using borrower > number. Something is wrong. Recommendation: Perhaps a prequel bug is in > order to deal with this patron image bug in self-checkout? I fixed this in this patch just by passing a parameter to the template that says an image exists. > And lastly the reason I'm Failing QA. > $selfchecktimeout -- Remnant left behind, which deals with system preference > not being set. > Logic in sco-main.tt line 343 does not deal with system preference not being > set. > Also line 419 in sco-main.tt was unchanged. > Recommendation: leave the logic for this as was OR put the logic into the TT > file. Decided to leave the logic for this as was. Ready for signoff -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
