https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072
--- Comment #10 from Lari Taskula <[email protected]> --- (In reply to Jonathan Druart from comment #8) > I'd suggest to swap $to, $from in the parameters. > ->can_be_transferred( $from, $to ) > sounds more logical. > When could even pass $hashref { from => $from, to => $to } to avoid > ambiguity. I used this particular order because one may leave $from undefined, in which case the item's holdingbranch will be used as $from, and the typical use case would be simply $item->can_be_transferred($to). I agree with your point for the advantage of using hashref. (In reply to Jonathan Druart from comment #9) > (In reply to Josef Moravec from comment #6) > > Created attachment 60010 [details] [review] [review] > > Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit > > functions > > Do you plan to replace this subroutine? No. I would like to replace all of them and write proper tests for that, but unfortunately I don't have time to work with that now. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
