https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18111

--- Comment #4 from M. Tompsett <[email protected]> ---
Comment on attachment 60216
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60216
Bug 18111: Fix import of default framework

Review of attachment 60216:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18111&attachment=60216)
-----------------------------------------------------------------

Overall, I like this cleaner code.

::: admin/import_export_framework.pl
@@ +53,5 @@
>  ## Exporting
>  if ($action eq 'export' && $input->request_method() eq 'GET') {
>      my $strXml = '';
> +    my $format = $input->param('type_export_' . $framework_name);
> +    ExportFramework('', \$strXml, $format);

Shouldn't this be $frameworkcode? You split the code and name logic, so the
code is set properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to