https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Mehdi Hamidi <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #29 from Mehdi Hamidi <[email protected]> ---
Hello everyone,
I rebased the patch and removed two patches that were not necessary.
I also addressed some of the the comments :

(In reply to Jonathan Druart from comment #23)

> ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
> @@ -111,4 @@
> >              <input type="checkbox" name="important" id="important" 
> > value="1" />
> >          [% END %]
> >      </li>
> > -    <li><label for="authorised_value">Authorized value: </label>[% 
> > authorised_value %] (if you select a value here, the indicators will be 
> > limited to the authorized value list)</li>
> 
> Why do you remove this line?

I put back the line, as for why it was removed, I'm not sure.

(In reply to Jonathan Druart from comment #24)
> QA comments:
> 1/ You have to deal with the items' fields too. I can mark a 995/952 field
> as important, but the behavior is not implemented when adding items.
> 2/ If a field is marked as important and mandatory, there are 2 stars (1 red
> and 1 black), is it the expected behavior? Maybe the importance of a field
> can be ignored if it is also marked as mandatory.

I did not fix the first point as it requires more development, but for your
second point I fixed it and it won't show important if the field is also
mandatory.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to