https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287
Mehdi Hamidi <mehdi.ham...@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehdi.ham...@inlibro.com --- Comment #30 from Mehdi Hamidi <mehdi.ham...@inlibro.com> --- The patch has been rebased on the current master. I made some changed to base on Jonathan comments. (In reply to Jonathan Druart from comment #26) > Suggestions: > What about moving all the cronjob prefs to a new "cronjob" tab? > What about a new pref to turn all of these prefs on/off? > > > Review: > 1/ Change in the behavior if the script is called without parameter (help is > not displayed anymore). > I think we should add a confirm flag if the pref will be used and --days is > not given. > 2/ +use English qw( -no_match_vars ); > why that? > 3/ It would have been good to use Pod2usage > > Failing QA for 1. 1- The script now show help if no parameter is passed and the system preference is not set. 2- I removed this line, apparently $PROGRAM_NAME needed it, so I changed the variable to $0 to display the name (relative path) of the script. 3- Maybe another patch. (In reply to Katrin Fischer from comment #27) > Just a note here - please think if systems with multiple instances. I have > run into several problems with other cronjobs lately :( It would be nice if > a move to sysprefs allows you to schedule it for all instances, while it > will only be active for ones with the pref set. Not sure if it's doable > without behaviour change... but you can make wishes, right? :) We'll keep this in mind :) This was just a rebase and minor changes. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/