https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #57 from Jonathan Druart <[email protected]> --- Kyle, I did not write the different failures because most of them are obvious: 1. There are no tests 2. CamelCase instead of snake_case for methods of Koha::Clubs and Koha::Patron 3. GetClubEnrollmentsCount and GetEnrollableClubsCount are not needed, just call ->count 4. You should not need to add GetBranches to the Branches TT plugin. Take a look at options_for_libraries 5. Subroutine added to Koha TT plugin (UserEnv), but not used. 6. Changes to circ/circulation.pl are not needed. A variable 'patron' is already passed to the template. 7. All the labels of the form has the same value for the "for" attribute. 8. Tables on clubs/clubs.pl are ugly (missing datatables.css?) 9. On /clubs/clubs-add-modify.pl?club_template_id=1, there is an empty input at the end of the form. 8. CGI->param must not be called in scalar context 9. When I save a form, I get "Your club was created" with a link to "Return to patron clubs". That sounds weird. Especially because the box is yellow. I'd suggest to behave as everywhere else in Koha: Save and get the list. I guess it's because there are too many small scripts, maybe it would have been easier to have a bigger one and have the different action handled in it (as everywhere else in admin scripts). 10. INSERT statements should have IGNORE in update db process 11. + `branchcode` varchar(10) COLLATE utf8_unicode_ci NULL DEFAULT NULL, you should not need to specify the COLLATE here. 12. QA tests do not pass FAIL Koha/Patron.pm FAIL forbidden patterns forbidden pattern: merge marker (>>>>>>>) (line 647) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
