https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022
--- Comment #9 from Jonathan Druart <[email protected]> --- Created attachment 60647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60647&action=edit Bug 18022: Fix possible crash if CircAutoPrintQuickSlip=clear screen If CircAutoPrintQuickSlip is set to clear screen, the $borrowernumber variable is reset but $borrower. In 16.11.x and before that causes the app to crash, because $borrower->{flags} is set to a hashref by GetMemberDetails, if $borrowernumber is set. This case is better handled in master (17.05) but side-effects could happen: if $borrowernumber is reset, $borrower should be reset too. The way to drive this behaviour is terrible and lot of things should be done to clean this area. This patch is a quick and easy fix to make it backportable easily. Test plan: On master, no change expected On 16.11 and before: 0. Set CircAutoPrintQuickSlip=clear screen 1. Create a new patron 2. Set permission for this patron to 'reservesforothers' (or something else). 3. Go on the circulation tab 4. Do not fill the barcode input and submit => Without this patch you will get an error Can't use string ("64") as a HASH ref while "strict refs".... => With this patch apply you will get a blank screen (expected behaviour). I would recommend to test this patch with the other value of CircAutoPrintQuickSlip as well -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
